Files
warp-engine-client/src/infrastructure/engine/ReleasePicker.ts
T
mr.zeroandClaude Opus 5 06f3f2a3b1
ci/woodpecker/push/woodpecker Pipeline was successful
ci/woodpecker/tag/woodpecker Pipeline was successful
The store engine moves into the client, and Python goes with it
Reading the catalog, choosing the release that fits this machine, unpacking it,
writing the menu entry and remembering what went where all happen in process now.
There is no interpreter to find, no child process, and no JSON-lines protocol
between the two halves — `PythonEngineProcessRunner`, the runtime locator, the two
engine mappers and the version negotiation are all gone, and with them the one
unchecked cast this codebase had (engine stdout to a typed event).

What that buys a person: on Windows and on a fresh Mac the app simply works. It
used to look for `python3`, `python` and `py -3` and draw a link to python.org
where none answered.

What lands on disk is unchanged, deliberately. `config.json` and `state.json` keep
the shell engine's snake_case shape, its `<scope>:<name>` keys and its file modes,
so a machine whose library was installed by the CLI keeps it — verified against the
Python engine on the same catalog: the same 13-title listing with zero field
differences, byte-identical payloads, identical modes and an identical Info.plist,
and a re-sync over a Python-installed home that writes nothing. Remove, prune,
prune-suppression on a named sync and the v1 state migration were each exercised.

Three things worth knowing about the new code:

  - the zip reader is ~150 lines over `node:zlib`, because Node has none and this
    application has no runtime dependencies. It restores the executable bit from
    each entry's external attributes, without which nothing installed can start,
    and it refuses zip64, unknown compression and paths that escape the
    destination rather than guessing;

  - `SUPPORTED_WARP_ENGINE_VERSIONS` names the engine versions this client is
    written against, checked against the `WarpEngine-Version` header every
    response carries. `selectCatalogDialect` switches over that list exhaustively,
    so adding a version fails the build — type checker and linter both — until
    somebody says what its catalog reads like. An absent header is read as the
    oldest version, which is what an engine before 0.4.0 is;

  - refresh and the language picker are icons at the foot of the side menu now,
    both named for a tooltip and a screen reader, the picker still a real
    `<select>` under its glyph.

The repository is free of Python as well: the Makefile, the CI check and the
release script read package.json and the forge's JSON with Node.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-18 23:36:25 +02:00

56 lines
1.9 KiB
TypeScript

import path from 'node:path'
import type { CatalogRelease } from './dialects/CatalogDialect'
export interface PickedRelease {
readonly version: string
readonly createdAt: string | null
readonly assetName: string
readonly kind: string
readonly assetPath: string
}
/** `/file/blessingofra-2.0.0.prg` -> `blessingofra-2.0.0.prg`. */
export function assetBasename (assetPath: string): string {
return path.posix.basename(assetPath.replace(/\/+$/, ''))
}
/**
* The newest non-dev release that carries an asset kind we can use.
*
* The candidates arrive newest-first from the dialect, which is where knowing that the
* API sorts them lives. Two rules decide the rest:
*
* **Release order wins over kind order.** The newest release that has *any* acceptable
* kind is taken, and within it the most preferred kind. That is what a desktop host
* wants: on Apple Silicon `mac_universal` beats `mac_x64`, which would need Rosetta,
* but not at the price of installing an older release.
*
* **A `dev-` build is never taken.** It is a moving target, and installing one would
* leave a menu entry pointing at an archive that is replaced without a version change.
*/
export function pickRelease (
candidates: readonly CatalogRelease[],
kinds: readonly string[],
extension: string
): PickedRelease | null {
for (const release of candidates) {
if (release.version.startsWith('dev-')) continue
for (const kind of kinds) {
for (const asset of release.assets) {
if (asset.kind !== kind) continue
const assetName = assetBasename(asset.path)
if (assetName.length === 0) continue
if (extension.length > 0 && !assetName.toLowerCase().endsWith(extension.toLowerCase())) continue
return {
version: release.version,
createdAt: release.createdAt,
assetName,
kind,
assetPath: asset.path
}
}
}
}
return null
}