Files
warp-engine-client/src/main/streams/WindowStreamBroadcaster.ts
T
mr.zeroandClaude Opus 5 26c7aa9be1
ci/woodpecker/push/woodpecker Pipeline was successful
A catalog that can say a title is not yours
A store with paid titles had nothing to tell this client and no way for it to
listen: the catalog carried no price, no entitlement and no sign-in, so a gated
download could only come back 403 and leave the window guessing why.

The knowledge belongs on the server, not here. This client serves whichever
catalog a registry names, so anything it knew about a particular shop would be
a rule that breaks every other one. WarpEngine 0.5 answers GET /api/service with
what it offers and puts an `access` block on every entry; this reads both. There
is no store name anywhere in the diff.

- **0.5 is a dialect of its own**, the older shape with `access` added. The
  version list is exhaustive over the selector, so adding it was a compile error
  until somebody said what it reads like — which is what that switch is for.
- **A card shows a price and a Buy button** when a title is not yours, opening
  the store's own page. Buying stays in a browser: a checkout rebuilt here would
  be a second place to get card handling wrong.
- **Signing in is the device grant**: a short code, the person's own browser, and
  no password crossing this window. The token goes in the OS keychain through
  safeStorage — one per store — and where no keychain exists it is not stored at
  all rather than written out in the clear.
- **Owned / To buy** join the categories, since owning something is not the same
  as having installed it.

Three things worth stating about the shape:

The bearer token stops at the origin that issued it. A gated download redirects
to signed storage — often somebody else's host — and some object stores refuse a
request outright when an Authorization header arrives alongside the signature.

An absent access block is not "free". It is an engine too old to have an
opinion, and only one of those two is a reason to offer somebody a sign-in, so
the three states are kept apart all the way to the card.

state.json does not carry entitlement. Whether somebody may download a title is
the server's answer to a question asked now; a copy on disk would go stale on the
next purchase or refund, and a stale yes is the dangerous direction.

A store with no sign-in shows none, and every WarpEngine before 0.5 is such a
store: no Account block, no prices, no new categories. The smoke test against the
live catalog reports exactly that — `sign-in: not offered`, `access: open:13`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-19 11:03:54 +02:00

60 lines
2.0 KiB
TypeScript

import type { BrowserWindow } from 'electron'
import type { EngineProgressListener } from '../../domain/models/EngineProgress'
import { IPC_CHANNELS } from '../../shared/contracts/IpcChannels'
import type { SignInFinishedDto } from '../../shared/contracts/dto/AccountDto'
import type { SyncEventDto } from '../../shared/contracts/dto/SyncEventDto'
/**
* The one-way streams to the window: log lines, progress events, busy state, and how a
* sign-in ended.
*
* Holds no window of its own — the reference is handed in when one exists and
* cleared when it does not, so a stream that outlives the window is a no-op rather
* than a crash.
*/
export class WindowStreamBroadcaster {
private window: BrowserWindow | null = null
public attachWindow (window: BrowserWindow): void {
this.window = window
}
public detachWindow (): void {
this.window = null
}
public publishLog (line: string): void {
this.send(IPC_CHANNELS.streamLog, line)
}
public publishSyncEvent (event: SyncEventDto): void {
this.send(IPC_CHANNELS.streamSyncEvent, event)
}
public publishBusyChanged (busy: boolean): void {
this.send(IPC_CHANNELS.streamBusyChanged, busy)
}
/**
* A sign-in finishes minutes after the call that started it returned, and in another
* window entirely — so it arrives as an event rather than as a reply.
*/
public publishSignInFinished (result: SignInFinishedDto): void {
this.send(IPC_CHANNELS.streamSignInFinished, result)
}
/** A progress listener wired to these streams, for handing to the engine. */
public asProgressListener (): EngineProgressListener {
return {
onLog: (line: string): void => { this.publishLog(line) },
onEvent: (event: SyncEventDto): void => { this.publishSyncEvent(event) }
}
}
private send (channel: string, payload: unknown): void {
const window = this.window
if (window === null || window.isDestroyed()) return
window.webContents.send(channel, payload)
}
}